feat(rule): Inline text spacing must be adjustable with custom stylesheets #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
changed the title
|
@straker as you have approved this, you will have to fill out the review checks above. |
WilcoFiers
previously requested changes
Apr 11, 2019
| "impact": "serious", | ||
| "messages": { | ||
| "pass": "No inline styles that affect text spacing has been specified", | ||
| "fail": "Inline styles that affect text spacing has been specified" |
There was a problem hiding this comment.
You'll need to include what style props are failing. Something like:
Remove
!importantfrom inline styles {= data =}, as overriding this not supported by most browsers
WilcoFiers
previously requested changes
Apr 12, 2019
WilcoFiers
previously requested changes
Apr 15, 2019
lib/rules/avoid-inline-spacing.json
Outdated
| "tags": ["wcag21", "wcag1412"], | ||
| "metadata": { | ||
| "description": "Ensure text spacing is not affected by inline spacing styles that affects CSS specificity", | ||
| "help": "Remove inline styles with '!important' that affect text spacing, as overriding this is not supported by most browsers" |
There was a problem hiding this comment.
Did a little more editing. I think the pass / fail ones are good. Can you change help/description to:
Description: Ensure that test spacing set through style attributes can be adjusted with custom stylesheets
Help: Inline text spacing must be adjustable with custom stylesheets
The browser thing is part of the fail message, we don't need to repeat that.
WilcoFiers
approved these changes
Apr 17, 2019
WilcoFiers
changed the title
stephenmathieson
added a commit
to mohanraj-r/axe-core
that referenced
this pull request
May 10, 2019
* develop: (50 commits) docs: add jsdom example and tests (dequelabs#1530) fix(aria-valid-attr-value): allow aria-owns to pass when element is not in the DOM (dequelabs#1526) fix(isSkipLink): cache first page link (dequelabs#1525) chore: update Babel dependencies (dequelabs#1527) chore(package): Update karma to version 4.1.0 (dequelabs#1528) feat: Improve perf of axe.run [WWD-1821] (dequelabs#1503) fix(prettier): ignore generated api doc files (dequelabs#1522) fix(skip-link,region): Allow multiple skiplinks at page top (dequelabs#1496) fix(raw-reporter): do not output `DqElement`s (dequelabs#1513) fix: Scroll state had top and left properties flipped (dequelabs#1469) refactor: commons.color.getBackgroundColor method (dequelabs#1451) fix(aria-valid-attr-value): allow aria-controls to pass when element is not in the DOM chore: Update husky to the latest version 🚀 (dequelabs#1514) style: format HTML files with Prettier (dequelabs#1508) test: Fix invalid test html (dequelabs#1502) feat(rule): Inline text spacing must be adjustable with custom stylesheets (dequelabs#1446) chore: Remove version number from axe.d.ts (dequelabs#1499) chore: Update make-dir to the latest version 🚀 (dequelabs#1465) fix: Exclude iframe for html-has-lang rule (Issue 1424) (dequelabs#1430) feat(utils): add support for complex CSS selectors (dequelabs#1494) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure text spacing is not affected by inline spacing styles that affects CSS specificity
Closes issue:
Note: to make sure to make it clear in the failure message that this is due to limited support for custom stylesheets.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)