Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple-labels rule not correct in shadow DOM #1559

Closed
WilcoFiers opened this issue May 10, 2019 · 1 comment
Closed

Multiple-labels rule not correct in shadow DOM #1559

WilcoFiers opened this issue May 10, 2019 · 1 comment
Assignees
@AutoSponge
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@WilcoFiers
Copy link
Contributor

Noticed this line:
https://github.com/dequelabs/axe-core/blob/develop/lib/checks/label/multiple-label.js#L2

Expectation: This rule checks for labels in the same DOM tree that the form field exists in

Actual: The rule checks the light DOM for labels with the same ID.
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule labels May 10, 2019
@AutoSponge AutoSponge self-assigned this May 22, 2019
@AutoSponge AutoSponge mentioned this issue May 22, 2019
Merged
4 tasks
@chandana7393
Copy link

Tested, working as expected.
multi_label_shadow_dom
Tested Environment:
Attest - 2.5.1.20021v
Axe - 3.8.1.19820v
Axe-coconut - 3.8.1.21104v
Chrome - 75.0.3770.142v
OS - Windows 10 64 bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AutoSponge AutoSponge

Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WilcoFiers @AutoSponge @chandana7393