feat(role-img-alt): Split rule for role=img with no accessible name #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutoSponge
force-pushed
the
fix-1192-role-img-alt
branch
3 times, most recently
from
d984b70
to
802260e
Compare
WilcoFiers
previously requested changes
May 24, 2019
lib/rules/role-img-alt.json
Outdated
| ], | ||
| "metadata": { | ||
| "description": "Ensures [role='img'] elements have alternate text", | ||
| "help": "Images must have alternate text" |
There was a problem hiding this comment.
Please change this to [role='img'] elements have an alternative text, to distinguish it from other "image" rules.
| @@ -0,0 +1,13 @@ | |||
| <div id="match">Bananas</div> | |||
| <div id="hidden-match" style="display:none">Banana bombs</div> | |||
There was a problem hiding this comment.
Did you mean to put role="img" here?
There was a problem hiding this comment.
No, that's purely for testing aria-labelledby, it's a pattern used in other alt tests.
AutoSponge
force-pushed
the
fix-1192-role-img-alt
branch
from
802260e
to
fdfd886
Compare
WilcoFiers
changed the title
WilcoFiers
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes
[role='img']selector fromimage-altrule.issue: #1192
Reviewer checks
Required fields, to be filled out by PR reviewer(s)