Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(valid-attr-value): Return incomplete when aria-describedby reference a missing element #1671

Merged
merged 1 commit into from Jul 8, 2019
Merged

fix(valid-attr-value): Return incomplete when aria-describedby reference a missing element #1671

merged 1 commit into from Jul 8, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 3, 2019 •
edited by WilcoFiers

Linked issue: #1151

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@straker straker requested a review from a team as a code owner July 3, 2019 15:05
@WilcoFiers WilcoFiers changed the title fix(valid-attr-value): allow aria-describedby to return needs review fix(valid-attr-value): Return incomplete when aria-describedby reference a missing element Jul 4, 2019
@straker straker merged commit 2390925 into develop Jul 8, 2019
@straker straker deleted the needsReviewIdrefs branch July 8, 2019 14:52
WilcoFiers pushed a commit that referenced this pull request Jul 22, 2019
@straker @WilcoFiers
fix(valid-attr-value): allow aria-describedby to return needs review (#…
af74239 
…1671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers