Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should color contrast matcher exclude aria-disabled=true on parent elements? #1766

Open
straker opened this issue Aug 14, 2019 · 1 comment
Labels
false negative rules Issue or false result from an axe-core rule

Comments

@straker
Copy link
Contributor

straker commented Aug 14, 2019

The color-contrast-matcher does not match elements if they have any parent node with aria-disabled=true. We should research if aria-disabled propagates to children properly and if the child is really disabled.

If not, we should check the element still and then mark it as needs review instead of failing if an ancestor has aria-disabled=true.

@straker straker added the info needed More information or research is needed to continue label Aug 14, 2019
@WilcoFiers
Copy link
Contributor

aria-disabled does cascade. What we could maybe do here is check what element the aria-disabled is on. If it's on a [role=group] or on a fieldset, that's a clear case of a disabled region. If it isn't, I agree that needs review might be better.

@WilcoFiers WilcoFiers added false negative rules Issue or false result from an axe-core rule and removed info needed More information or research is needed to continue labels Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false negative rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

2 participants