Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configure): use translations for failure summaries #1808

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Conversation

straker
Copy link
Contributor

@straker straker commented Sep 11, 2019

Use the failure summaries from the passed in locale.

Discovered a bug in the translation file generator (#1810) and had to make nl.json match the incorrect structure so we don't try to do too much in this PR. Will fix the structure and bug in another PR.

Closes issue: #1750

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner September 11, 2019 22:28
@straker straker merged commit 5e53d7b into develop Sep 25, 2019
@straker straker deleted the failureLocales branch September 25, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants