fix(color-contrast): ignore nodes that don't contain text #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutoSponge
reviewed
Oct 3, 2019
There was a problem hiding this comment.
Do we need a test for or other whitespace characters that DO take up space but do not have contrast (since they don't print anything)?
‏ seems very specialized and is one of the few <control> characters with an HTML entity, are we checking for U+0000 - U+001F, U+007F - U+009F, etc.?
|
|
WilcoFiers
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore nodes of only emoji, nonBMP unicode, and punctuation. Turns out this was a lot easier than I thought since I discovered we had the unicode functions.
Closes issue: #315
Reviewer checks
Required fields, to be filled out by PR reviewer(s)