Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axe reports "Buttons must have discernible text" but accessible name exists #1892

Closed
weboverhauls opened this issue Nov 12, 2019 · 6 comments
Assignees
Labels
docs Documentation changes fix Bug fixes rules Issue or false result from an axe-core rule
Milestone

Comments

@weboverhauls
Copy link

weboverhauls commented Nov 12, 2019

Axe reports false positive "Buttons must have discernible text"

Snippet:
<input type="submit" role="button" value="Login" id="olb-btn" disabled="disabled" style="color: rgb(85, 158, 203);">

Found on: https://www.pnc.com/en/personal-banking.html

Expectation: nothing reported

Actual: reports "Buttons must have discernible text"

Motivation: value provides the accessible name; shows as accessible name in Chrome Dev Tools; reads fine in VoiceOver/Safari

axe Chrome extension: v4.1.0 (axe-core 3.3.2)

@straker
Copy link
Contributor

straker commented Nov 12, 2019

Thanks for the issue. It seems the button <input type="submit" role="button" value="Login" id="olb-btn" disabled="disabled"> is giving us as issue as it does not have visible text, nor an aria-label or aria-labelledby. However, I tested this in JAWS/IE11, JAWS/Chrome, NVDA/Firefox, and VoiceOver/Safari, and all of them read it as "Login Button." I couldn't test it in Android/Talkback as that specific login form is missing from the mobile view.

@straker straker added fix Bug fixes rules Issue or false result from an axe-core rule labels Nov 12, 2019
@WilcoFiers WilcoFiers added this to the Axe-core 3.5 milestone Nov 13, 2019
@jeankaplansky
Copy link
Contributor

mention in release notes.

@padmavemulapati
Copy link

With the below code snippet:

<input type="submit" role="button" value="Login" id="olb-btn" disabled="disabled" style="color: rgb(85, 158, 203);">

Not reporting any voilation regarding "Buttons must have discernible text" , but without the above code seeing the issue . @Steve, what would be the QA expected here

@straker
Copy link
Contributor

straker commented Dec 2, 2019

@padmavemulapati QA expected would be the input passes the "Buttons must have discernible text" rule. Previously it was failing the rule.

@padmavemulapati
Copy link

Yes, with the "Buttons must have discernible text" rule, it is passing not failing the rule. So that the expectation. Closing the issue.

@dylanb
Copy link
Contributor

dylanb commented Dec 17, 2019

@WilcoFiers did we do the complete accessibility supported testing on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation changes fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

6 participants