Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scrollable-region-focusable): pass for elements with contenteditable #2133

Merged
merged 5 commits into from Apr 1, 2020
Merged

fix(scrollable-region-focusable): pass for elements with contenteditable #2133

merged 5 commits into from Apr 1, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Mar 25, 2020 •
edited by WilcoFiers

Closes issue: #2091

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner March 25, 2020 17:25
WilcoFiers
WilcoFiers previously approved these changes Mar 27, 2020
View reviewed changes
@straker straker mentioned this pull request Mar 30, 2020
Merged
2 tasks
@straker
Copy link
Contributor Author

straker commented Mar 30, 2020

The IE11 fix for this is in #2139

@WilcoFiers
Copy link
Contributor

Redid the security check too.

@straker straker merged commit 1012dfe into develop Apr 1, 2020
@straker straker deleted the contenteditable branch April 1, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers