Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more options for non-generic check evaluate functions #2195

Closed
6 tasks done
WilcoFiers opened this issue Apr 28, 2020 · 2 comments
Closed
6 tasks done

Provide more options for non-generic check evaluate functions #2195

WilcoFiers opened this issue Apr 28, 2020 · 2 comments
Assignees
Labels
configuration rules / checks customisation feat New feature or enhancement rules Issue or false result from an axe-core rule
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Apr 28, 2020

Adding these options will make it easier to configure these checks in custom rules:

  • Label/duplicate-img-label
    • Options for parent selector
  • Language/has-lang
    • Options for which attributes to look at
  • Language/valid-lang
    • Options for which attributes to look at
  • Navigation/region
    • Option for what elements are considered regions using a matcher
  • Shared/avoid-inline-spacing
    • Option for inline spacing css props
  • Tables/scope-value
    • Option for invalid values of scope

Other checks either already have options, they will be replaced with more general checks, or they will be configurable through commons.

@straker
Copy link
Contributor

straker commented Jun 11, 2020

QA: you'll need to look at each of the individual prs listed here to know what the options for each check is called.

@padmavemulapati
Copy link

padmavemulapati commented Jun 15, 2020

Seeing the changes on all Options (Options.value) and instead normal methods, observed getter methods and call funtions. Please let me know is there any specific impacts on tests/test results.

  1. duplicate-image-label - check verified with the test data - <div aria-label="Plain text"><img id="target" alt="Plain text"></div> , seeing the same results with old changes and new changes. As there is no impacts on results with the current changes.
  2. has-land - check verified with the test data - <div id="target" foo="cats"></div>
    like wise..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration rules / checks customisation feat New feature or enhancement rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

4 participants