Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(matches-definition): add generic check matches-definition #2233

Merged
merged 1 commit into from
May 18, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented May 15, 2020

There are a few checks we could replace with this if matches could handle things like "attribute is not empty" or "attribute is empty" type checks as well. Once we extend matches with role matching, there are a few more checks we can replace as well.

Closes issue: #2185

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner May 15, 2020 15:03
@straker straker merged commit 20467aa into develop May 18, 2020
@straker straker deleted the matches-definition branch May 18, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants