feat(color-contrast, utils): add more options to color-contrast, add utils.deepMerge, deprecate commons.color.hasValidContrastRatio #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ast ratio requirements
WilcoFiers
approved these changes
May 29, 2020
WilcoFiers
previously requested changes
May 29, 2020
WilcoFiers
reviewed
May 29, 2020
|
With nested options, the |
straker
changed the title
straker
changed the title
straker
commented
Jul 2, 2020
lib/checks/color/color-contrast.json
Outdated
| "normal": { | ||
| "expected": 4.5, | ||
| "minThreshold": 0, | ||
| "maxThreshold": 999 |
There was a problem hiding this comment.
This number is arbitrary. It just needed to be something larger than the contrast ratio could ever go (#fff vs #000 = 21:1)
WilcoFiers
previously requested changes
Jul 3, 2020
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
requested changes
Jul 7, 2020
WilcoFiers
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to have options to specify the minimum contrast the check should apply to allow rules a specific range of contrast to determine pass/fail.
Closes issue: #2175
Reviewer checks
Required fields, to be filled out by PR reviewer(s)