New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page-has-h1): allow aria-level=1 on native headings #2349

Merged

WilcoFiers merged 1 commit into develop from page-has-h1-fix

Jul 8, 2020

Contributor

WilcoFiers commented Jul 8, 2020 •

edited by straker

Properly take aria-level into account for page-has-heading-one

Closes issue: #2348

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

Follows the commit message policy, appropriate for next version
Code is reviewed for security


          fix(page-has-h1): allow aria-level=1 on native headings

217a342

WilcoFiers requested a review from a team as a code owner

July 8, 2020 12:08

straker approved these changes

View reviewed changes

WilcoFiers merged commit 70b10b2 into develop

WilcoFiers deleted the page-has-h1-fix branch

July 8, 2020 15:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment