Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria/allowed-attr): work with standards object #2360

Merged
merged 2 commits into from Jul 13, 2020
Merged

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 10, 2020

Refactored allowedAttr to have a better happy path and return early if no role def was found, also didn't need to concat everything. Since getting global attrs is found in a lot of code, went ahead and cached the result as it shouldn't change during a run.

The integration tests were expected from the diff in our lookup table in #2328 (comment)

Part of #2108

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 10, 2020 16:21
@straker straker changed the title fix(allowed-attr): work with standards object fix(aria/allowed-attr): work with standards object Jul 10, 2020
@straker straker merged commit 40397f5 into develop Jul 13, 2020
@straker straker deleted the allowed-attr branch July 13, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants