Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(standards): add get-elements-by-content-type and implicit-html-roles #2375

Merged
merged 3 commits into from
Jul 16, 2020
Merged

feat(standards): add get-elements-by-content-type and implicit-html-roles #2375

merged 3 commits into from
Jul 16, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 14, 2020 •
edited by WilcoFiers
Loading

Also a chore to move implicit role to use them.

Part of issue #2108

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 14, 2020 16:50
WilcoFiers
WilcoFiers previously requested changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda stumped about what this is intended to do.

lib/commons/standards/implicit-html-roles.js Show resolved Hide resolved
@straker straker merged commit f1e0848 into develop Jul 16, 2020
@straker straker deleted the implicit-role branch July 16, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers