feat(rule): optional impact on rules #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously requested changes
Jul 17, 2020
doc/API.md
Outdated
| @@ -202,7 +202,7 @@ axe.configure({ | |||
| - `rules` - Used to add rules to the existing set of rules, or to override the properties of existing rules | |||
| - The rules attribute is an Array of rule objects | |||
| - each rule object can contain the following attributes | |||
| - `id` - string(required). This uniquely identifies the rule. If the rule already exists, it will be overridden with any of the attributes supplied. The attributes below that are marked required, are only required for new rules. | |||
| - `id` - string(required). This uniquely identifies the rule. If the rule already exists, it will be overridden with any of the attributes supplied. The attributes below that are marked required, are only required for new rules. - `impact` - string(optional). Override the impact defined by checks | |||
There was a problem hiding this comment.
Looks like a newline is needed before the impact list item. Right now it's part of the same paragraph as id.
straker
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows an impact property on rules, which if used overrides the impact of all checks for that rule.
Includes the deletion of the unreleased
has-accessible-textcheck, which was added because axe-core did not support this feature.Closes issue: #693
Reviewer checks
Required fields, to be filled out by PR reviewer(s)