fix(rule,check): allow function ids for matches property in rule.configure #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,14 @@ export function createExecutionContext(spec) { | |||
| return metadataFunctionMap[spec]; | |||
| } | |||
|
|
|||
| return new Function('return ' + spec + ';')(); | |||
| // execution contexts can only be functions | |||
| if (/^\s*function[\s\w]*\(/.test(spec)) { | |||
There was a problem hiding this comment.
What about "arrow functions"?
| return this.evaluate(); | ||
| }; | ||
| var check = new Check({ | ||
| evaluate: 'function () { return "foo"; }' |
There was a problem hiding this comment.
What happens if we do this:
evaluate: '() => "foo"'There was a problem hiding this comment.
As far as I know we don't allow that. Although it is possible, we only support doT.js template output which uses functions.
@WilcoFiers do you find this a problem (especially since we deprecated this?)
There was a problem hiding this comment.
I don't think this is a problem, no.
WilcoFiers
approved these changes
Jul 28, 2020
| return this.evaluate(); | ||
| }; | ||
| var check = new Check({ | ||
| evaluate: 'function () { return "foo"; }' |
There was a problem hiding this comment.
I don't think this is a problem, no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@downzer0 discovered this one when trying to configure a rule with a
matchesfunction ID. I added tests to ensure this should work now as well as throw a more helpful message as the default was eval the string as code and you'd get athing is not definederror which was super unhelpful. So now you should get an error with the name of the string you used.Reviewer checks
Required fields, to be filled out by PR reviewer(s)