Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(required-parent): fail if intermediate role is not the required parent #2494

Merged
merged 5 commits into from
Aug 28, 2020
Merged

fix(required-parent): fail if intermediate role is not the required parent #2494

merged 5 commits into from
Aug 28, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Aug 26, 2020 •
edited by WilcoFiers
Loading

Closes issue: #2012

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner August 26, 2020 22:08
@straker straker merged commit 782c0fd into develop Aug 28, 2020
@straker straker deleted the required-parent-intermediate branch August 28, 2020 17:39
straker added a commit that referenced this pull request Sep 8, 2020
@straker
fix(required-parent): fail if intermediate role is not the required p…
522865c 
…arent (#2494)

* fix(required-parent): fail if intermediate role is not the required parent

* allow presentational intermediate roles

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers