fix(object-alt): do not allow fallback content for objects #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
force-pushed
the
object-alt-fix
branch
3 times, most recently
from
0c573b4
to
08b1f67
Compare
straker
previously requested changes
Sep 21, 2020
test/playground.html
Outdated
| @@ -2,7 +2,68 @@ | |||
| <html lang="en"> | |||
| <title>O hai</title> | |||
|
|
|||
| <div class="foo" id="foo">foo</div> | |||
| <div class="listbox-area"> | |||
There was a problem hiding this comment.
Glad I'm not the only one who submits changes to the playground file :)
There was a problem hiding this comment.
whahaha, fair enough :P
WilcoFiers
force-pushed
the
object-alt-fix
branch
from
08b1f67
to
798426d
Compare
straker
approved these changes
Sep 22, 2020
straker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback content can not be used to give an object an accessible name. Instead us aria-label(ledby) or title.
Closes issue: #2524
Reviewer checks
Required fields, to be filled out by PR reviewer(s)