feat(imports): deprecate axios #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM!
I always thought axios was overkill here, and figured replacing it with unfetch would be an easy performance win. Using the native XMLHttpRequest makes sense too tho :)
While I'm hugely on-board with this change, I think it's best to wait for review from @WilcoFiers or @dylanb, as it involves changing the API.
WilcoFiers
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate our use of axios for a single request, which when we can remove it will reduce our minified and gzipped file size by 5 kB. This will also help our transfer to Rollup as axios caused some issues when trying to use the node resolve rollup plugin.
Part of #2357
Reviewer checks
Required fields, to be filled out by PR reviewer(s)