feat(new-rule): ARIA links, buttons, menuitems have an accessible name #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Oct 20, 2020
Comment on lines
24
to
29
| <script src="area-alt.js"></script> | ||
| <script src="aria-input-field-name.js"></script> | ||
| <script src="aria-menuitem-name.js"></script> | ||
| <script src="aria-progressbar-name.js"></script> | ||
| <script src="aria-toggle-field-name.js"></script> | ||
| <script src="aria-tooltip-name.js"></script> |
There was a problem hiding this comment.
We need to think of a way to make sure we don't forget to do this. Any thoughts?
There was a problem hiding this comment.
We could generate the file like we do the other test html files. I've not looked into that part of the build but it should be possible.
11 tasks
straker
previously approved these changes
Oct 21, 2020
Comment on lines
24
to
29
| <script src="area-alt.js"></script> | ||
| <script src="aria-input-field-name.js"></script> | ||
| <script src="aria-menuitem-name.js"></script> | ||
| <script src="aria-progressbar-name.js"></script> | ||
| <script src="aria-toggle-field-name.js"></script> | ||
| <script src="aria-tooltip-name.js"></script> |
There was a problem hiding this comment.
We could generate the file like we do the other test html files. I've not looked into that part of the build but it should be possible.
WilcoFiers
changed the title
WilcoFiers
changed the title
WilcoFiers
commented
Oct 22, 2020
Comment on lines
-202
to
+204
| conform: function hasCategoryTag(tags) { return tags.some(tag => tag.includes('cat.')) }, | ||
| conform: function hasCategoryTag(tags) { | ||
| return tags.some(tag => tag.includes('cat.')); | ||
| }, |
There was a problem hiding this comment.
Hmm, not sure how that didn't make it in last PR. Shouldn't matter.
straker
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ARIA link and button testing to this new aria-command-name rule, out of link-name / button-name. This closes issue #2582 and #2577.
Requires #2584 to be merged.
Part of #2421
Reviewer checks
Required fields, to be filled out by PR reviewer(s)