Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utils): deprecate get/set-scroll-state #2581

Merged
merged 1 commit into from
Oct 22, 2020
Merged

feat(utils): deprecate get/set-scroll-state #2581

merged 1 commit into from
Oct 22, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Oct 21, 2020 •
edited by WilcoFiers
Loading

Closes issue: #2412

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner October 21, 2020 19:33
@straker straker merged commit 3c4827f into develop Oct 22, 2020
@straker straker deleted the deprecate-scroll-state branch October 22, 2020 15:24
@mohanraj-r
Copy link
Contributor

Does this mean the restoreScroll option would be deprecated as well?
Is this related to #2388 ?
Was the option only applicable for color-contrast check ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@straker @mohanraj-r @WilcoFiers