Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aria-toggle-field-name): add option role #2605

Merged
merged 1 commit into from
Oct 29, 2020
Merged

feat(aria-toggle-field-name): add option role #2605

merged 1 commit into from
Oct 29, 2020

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Oct 28, 2020 •
edited by straker
Loading

Test that elements with role=option have an accessible name. There's really no good reason for empty options to exist that I can think of, so those should be flag up.

Part of issue #2421

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@WilcoFiers WilcoFiers requested a review from a team as a code owner October 28, 2020 12:59
@WilcoFiers WilcoFiers mentioned this pull request Oct 28, 2020
Closed
11 tasks
@WilcoFiers WilcoFiers merged commit 0af0551 into develop Oct 29, 2020
@WilcoFiers WilcoFiers deleted the aria-option-name branch October 29, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilcoFiers @straker