Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(region): treat iframes as regions #2614

Merged
merged 1 commit into from
Nov 2, 2020
Merged

fix(region): treat iframes as regions #2614

merged 1 commit into from
Nov 2, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Oct 30, 2020 •
edited by WilcoFiers
Loading

Treat iframes as regions. If content inside the iframe does not have a region, we'll get a report on just that content.

Closes issue: #2330

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner October 30, 2020 16:33
WilcoFiers
WilcoFiers approved these changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that did turn out to be much easier.

@straker straker merged commit 936db81 into develop Nov 2, 2020
@straker straker deleted the region-iframe branch November 2, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers