New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commons/get-text-element-stack): account for newline characters when text is larger than container #2631

Merged

straker merged 1 commit into develop from newline-text

Nov 10, 2020

Contributor

straker commented Nov 10, 2020 •

edited by WilcoFiers

Loading

Padma found that if there was whitespace before the text my code didn't fix the issue. This change should address that.

Closes issue: #2483

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

Follows the commit message policy, appropriate for next version
Code is reviewed for security


          fix(commons/get-text-element-stack): account for newline characters w…

72ec441

…hen text is larger than container

straker requested a review from a team as a code owner

November 10, 2020 16:18

WilcoFiers approved these changes

View reviewed changes

straker merged commit 3c2429b into develop

straker deleted the newline-text branch

November 10, 2020 16:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment