New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid 'undefined' showing in check messages #2779

Merged

WilcoFiers merged 1 commit into develop from str-replace-fix

Jan 26, 2021

Contributor

WilcoFiers commented Jan 25, 2021

Sometimes "undefined" can get into the data object. Especially "messageKey" can be undefined at times. This PR does two things:

It prevents "undefined" from ever showing in the message.
It ensures that buggy implementations of string.replace() always get a string passed as its second argument. The later one caused issues on a customer website.


          fix: avoid 'undefined' showing in check messages

57cc35e

WilcoFiers requested a review from a team as a code owner

January 25, 2021 10:25

dylanb approved these changes

View reviewed changes

WilcoFiers merged commit 3beb0b1 into develop

WilcoFiers deleted the str-replace-fix branch

January 26, 2021 10:31

WilcoFiers mentioned this pull request

chore(release): version 4.2.0 #2886

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment