fix(respondable): Avoid message duplication with messageId #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Feb 23, 2021
Comment on lines
+48
to
+49
| respondable.subscribe('axe.start', runCommand); | ||
| respondable.subscribe('axe.ping', (data, keepalive, respond) => { |
There was a problem hiding this comment.
Pulled these out to avoid registering them each time load is called.
dylanb
previously approved these changes
Feb 23, 2021
|
Approved but please look into the Windows failures and fix before a release |
WilcoFiers
force-pushed
the
respondable-rewrite
branch
from
5602493
to
8a52af2
Compare
straker
previously requested changes
Feb 23, 2021
WilcoFiers
force-pushed
the
respondable-rewrite
branch
from
8a52af2
to
1acc2cb
Compare
WilcoFiers
force-pushed
the
respondable-rewrite
branch
from
1acc2cb
to
6a6be9f
Compare
straker
previously approved these changes
Feb 24, 2021
WilcoFiers
changed the title
dylanb
previously approved these changes
Feb 26, 2021
straker
approved these changes
Mar 1, 2021
straker
pushed a commit
that referenced
this pull request
Mar 2, 2021
* refactor: rewrite respondable
* fix: use nodejs crypto for uuid.v4
* test(cmd): allow require('crypto')
straker
added a commit
that referenced
this pull request
Mar 4, 2021
* fix(types): Add noHtml option (#2810) * Add noHtml to the typescript types * Update axe.d.ts Co-authored-by: Stephen Mathieson <me@stephenmathieson.com> * fix(respondable): Avoid message duplication with messageId (#2816) * refactor: rewrite respondable * fix: use nodejs crypto for uuid.v4 * test(cmd): allow require('crypto') * tests: fix respondable tests * remove failing tests * chore(release): 4.1.3 Co-authored-by: Dylan Barrell <dylan@barrell.com> Co-authored-by: Stephen Mathieson <me@stephenmathieson.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a precursor to us adding custom message listeners to axe-core. Those would allow communication between windows without using window.postMessage, which can interfere with other scripts in a page, especially in environments like browser extensions.
This rewrite patches up a number of gaps as well. It gives every message a unique ID to avoid a message accidentally getting accepted twice. It now does a better job of logging invalid messages, and behavior between subscribers and responders has been made consistent.
This respondable implementation also prevents overriding the subscriber, which is why a lot of tests had to be tweaked.