fix(autocomplete-appropriate): pass for autocomplete=username and type=email #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
straker
previously requested changes
Apr 27, 2021
| @@ -12,6 +12,7 @@ function autocompleteAppropriateEvaluate(node, options, virtualNode) { | |||
| const allowedTypesMap = { | |||
| bday: ['text', 'search', 'date'], | |||
| email: ['text', 'search', 'email'], | |||
| username: ['email'], | |||
There was a problem hiding this comment.
I believe to fix the test we'll need this to also include text and probably search. Otherwise it's restricted to just type=email.
There was a problem hiding this comment.
Ah! That makes sense, thanks for the hint. :)
straker
changed the title
|
Sorry one last thing. Could you add an integration test for the new combination? |
|
Reviewed for security |
straker
pushed a commit
that referenced
this pull request
May 18, 2021
…e=email (#2896) * allow type=email autocomplete=username * also add text and search * add integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #2727, allow the
autocomplete-appropriaterule to pass for an input like<input type='email' autocomplete='username' >Also fixes spacing in the name of a test for autocomplete-valid.
Closes issue: #2727