feat: deprecate autocomplete appropriate check #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
requested changes
May 13, 2021
|
@straker I'm not sure what you mean by that, would you mind being more specific? I did notice looking at some other deprecated checks that the impact for the others was 'minor' - it makes sense to me that a deprecated check shouldn't be a severe impact, so I made that change. Can reverse it if that was the wrong call. |
|
Ah I think I figured it out! :D |
|
Sorry missed the first question. Yes you removed it correctly. As for the impact change I don't think we should do that as the impact is based on user testing. The tests will also need to be updated with the removal of the check as those failures will no longer fail. |
WilcoFiers
approved these changes
Jun 3, 2021
|
Reviewed for security. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates autocomplete-appropriate
Closes issue: #2912