fix(aria-allowed-attr): allow aria-posinset and aria-setsize on row elements for treegrids #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
requested changes
May 21, 2021
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
May 25, 2021
|
Reviewed for security. |
straker
pushed a commit
that referenced
this pull request
Jun 3, 2021
…lements for treegrids (#2952) * allow posinset and setsize on row elements * remove update from lookup table Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds aria-posinset and aria-setsize to the allowed aria attributes for row elements, in accordance with the treegrid examples.
See a live test case on glitch, which runs a local copy of axe that's been built with these changes.
When I run this locally, the test I added isn't getting picked up and I'm not sure why - might need to pair on that.
Closes #2720