Failure summary for "empty-table-header" is confusing for empty th

[connorjclark]

Product: axe-core

Expectation:

<table>
  <tr>
    <th></th>
  </tr>
</table>

Rule should fail saying: Element does not have text that is visible to screen readers

Actual:

Rule is marked incomplete and says: Unable to determine if element has children

Motivation: More immediate advice.

axe-core version: 4.2.1

[straker]

Figured it out. Turns out that we marked the rule to return as Needs Review rather than failure when there is no text content. However, this causes the check to use the incomplete message rather than the failure message.

It's important to note that we do want the rule to be marked as incomplete and not fail as there are legit reasons a table header could be empty. See #2604

Since we want the rule to return as needs review by default, but also keep the Unable to determine if element has children message if the code errors, we might need to create a separate check instead of leveraging the has-visible-text one.

[padmavemulapati]

Validated with the latest develop branch code base,
Earlier it was displaying as Unable to determine if element has children
Now it is appearing as Element does not have text that is visible to screen readers
Before changes:

after changes: