fix(color-contrast): check for pseudo elements on element itself, not just parents #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clottman
changed the title
WilcoFiers
approved these changes
Jun 7, 2021
|
Reviewed for security |
WilcoFiers
pushed a commit
that referenced
this pull request
Jun 17, 2021
straker
pushed a commit
that referenced
this pull request
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should return elements as Needs Review/incomplete if there is a pseudo element on the element, not just if any of the element's parents have pseudo elements. This PR makes that the case.
Closes issue: #2966