feat(runPartial): Test without frame communication #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
reviewed
Jun 29, 2021
lib/core/public/run-partial.js
Outdated
| }) | ||
| .then(data => { | ||
| // TODO: Proper copy with .toJSON call instead of this; | ||
| const results = JSON.parse(JSON.stringify(data)); |
There was a problem hiding this comment.
Why copy the results from data if we're just returning it?
lib/core/public/finish-run.js
Outdated
| import { getReporter } from './reporter'; | ||
| import { mergeResults, publishMetaData, finalizeRuleResult, DqElement } from '../utils'; | ||
|
|
||
| export default function finishRun(data, options = {}) { |
There was a problem hiding this comment.
It wasn't clear what data was in this function, had to read the tests to understand it was an array of runPartial results.
| ).then(function (partialResults) { | ||
| return Promise.all([ | ||
| axe.finishRun(partialResults, options), | ||
| axe.run(clone(context), options) |
There was a problem hiding this comment.
Was confused why you were running axe.run here. Looking further into the test I see you're making sure they are the same result. Might be better if this sort of test was first defined like:
"it(should give the same results as axe.run)"
WilcoFiers
commented
Jul 1, 2021
| function runPartial( | ||
| context: ElementContext, | ||
| options: RunOptions | ||
| ): Promise<unknown>; |
There was a problem hiding this comment.
Techdebt ticket here: #3059
WilcoFiers
changed the title
WilcoFiers
commented
Jul 1, 2021
| var attrName = attrs[i].name; | ||
| if (attrName !== 'id') { | ||
| fixture.removeAttribute(attrs[i].name); | ||
| if (typeof beforeEach !== 'undefined' && typeof afterEach !== 'undefined') { |
There was a problem hiding this comment.
I put this in so that we can use testutils outside a test run. I was using it in playground.
straker
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new methods to the
axeobject.axe.runPartialruns axe in the current window, and collects information about its iframes.axe.finishRuntakes information from multipleaxe.runPartialcalls from different windows, builds a report from it.Closes #2936