fix(accText): ignore text in embedded content elements #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Jun 18, 2021
| @@ -674,7 +674,7 @@ const htmlElms = { | |||
| noAriaAttrs: true | |||
| }, | |||
| picture: { | |||
| contentTypes: ['embedded', 'phrasing', 'flow'], | |||
| contentTypes: ['phrasing', 'flow'], | |||
There was a problem hiding this comment.
This was a mistake. figure is not an embedded element. The img inside it is. You can put text inside a picture along side the img and the text will be rendered. It also isn't described as embedded in the HTML spec:
https://html.spec.whatwg.org/multipage/grouping-content.html#the-figure-element
WilcoFiers
commented
Jun 18, 2021
| var params = checkSetup('<object id="target"></object>'); | ||
| var params = checkSetup('<p id="target"></p>'); |
There was a problem hiding this comment.
Don't know why we did that. Clearly that's wrong.
WilcoFiers
force-pushed
the
embedded-text
branch
from
7bd16a4
to
b0c219c
Compare
WilcoFiers
commented
Jun 21, 2021
straker
previously requested changes
Jun 21, 2021
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
dylanb
approved these changes
Jun 22, 2021
straker
added a commit
that referenced
this pull request
Jun 22, 2021
* fix(accText): ignore text in embedded content elements Closes #3017 * Update lib/standards/html-elms.js * Update lib/standards/html-elms.js Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content inside embedded elements like
video,canvas,object, etc. should be ignored in computing the accessible name.Closes issue #3017