fix: Remove unnecessary files from npm package #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just had to manually publish `@next`, as [a `develop` build failed](https://app.circleci.com/pipelines/github/dequelabs/axe-core/2462/workflows/19d5c98e-c7e4-4a85-87f1-3503179ac326/jobs/33275). When doing this, I noticed how many things are included in the tarball we send to npm. This patch drastically reduces the size of the tarball and the number of files it contains. Previously: ``` npm notice === Tarball Details === npm notice name: axe-core npm notice package size: 811.9 kB npm notice unpacked size: 3.5 MB npm notice total files: 689 ``` Now: ``` npm notice === Tarball Details === npm notice name: axe-core npm notice package size: 314.3 kB npm notice unpacked size: 1.5 MB npm notice total files: 7 ``` This will hopefully reduce the chance of another failed upload.
straker
previously approved these changes
Jul 6, 2021
There was a problem hiding this comment.
I believe these are all the files we need, but @WilcoFiers should also approve so we don't mess it up.
WilcoFiers
previously requested changes
Jul 7, 2021
| "axe.js", | ||
| "axe.min.js", | ||
| "axe.d.ts", | ||
| "locales/" |
There was a problem hiding this comment.
Suggested change
| "locales/" | |
| "LICENSE", | |
| "locales/" |
There was a problem hiding this comment.
npm includes this itself.
Good catch. I'll remove the |
stephenmathieson
dismissed
WilcoFiers’s stale review
Suggested change is redundant; removed .npmignore
WilcoFiers
approved these changes
Jul 8, 2021
| "axe.js", | ||
| "axe.min.js", | ||
| "axe.d.ts", | ||
| "locales/" |
WilcoFiers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just had to manually publish
@next, as adevelopbuild failed. When doing this, I noticed how many things are included in the tarball we send to npm. This patch drastically reduces the size of the tarball and the number of files it contains.Previously:
Now:
This will hopefully reduce the chance of another failed upload.