fix(color-contrast): correctly handle nested scroll regions #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
approved these changes
Oct 15, 2021
straker
added a commit
that referenced
this pull request
Oct 18, 2021
* fix(color-contrast): correctly handle nested scroll regions * revert changes from previous pr
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code checked the cache of the direct parent first instead of checking if the parent was itself a scroll region, causing the code to skip the parent if it was scroll region and instead use the next level up scroll region. This means that the code ignored the background from the parent scroll region and used the next level up scroll regions background (causing all the false positives).
Closes issue: #2728