chore(i18n): update Japanese translation #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunt translate --lang=ja based on the develop branch as of 2021-12-03
Add ja translation for checks/aria-errormessage/fail/hidden
Add ja translation for checks/aria-errormessage/incomplete/idrefs
add ja translation for checks/aria-level/{pass,fail}
Add ja translation for checks/aria-valid-attr-value/incomplete/idrefs
Add ja transation for checks/deprecatedrole/{pass,fail}
Add ja translation for checks/fallbackrole/incomplete
add ja translation for checks/p-as-heading/incomplete
Add ja translation for checks/color-contrast-enhanced/fail/*
Add ja translation for checks/color-contrast/fail/*
|
Quick update on this. I'm looking for help on the review. You'll see it come up when it's there. Thank you once again for your contributions @ma10! |
|
Just to give a quick update on this. Not having much luck finding a reviewer. Still working on it though. We didn't forget. |
kiyochika
suggested changes
Mar 3, 2022
There was a problem hiding this comment.
@ma10 @WilcoFiers Really sorry for taking a long time on the review. I have tried to adjust the details such as the usage of spaces, but still cannot take enough time for doing so. But now I have just reviewed on only nessesary and it should be good to go if the lines with my comments are fixed.
| @@ -420,17 +420,23 @@ | |||
| "pass": "サポートされているaria-errormessageの技術を使用しています", | |||
| "fail": { | |||
| "singular": "aria-errormessage の値 `${data.values}` はメッセージを通知する方法を使用しなければなりません (例えば、aria-live、aria-describedby、role=alert等)", | |||
| "plural": "aria-errormessage の値 `${data.values}` はメッセージを通知する方法を使用しなければなりません (例えば、aria-live、aria-describedby、role=alert等)" | |||
| "plural": "aria-errormessage の値 `${data.values}` はメッセージを通知する方法を使用しなければなりません (例えば、aria-live、aria-describedby、role=alert等)", | |||
| "hidden": "aria-errormessage の値 `${data.values}` は隠れている要素を参照することはできません" | |||
There was a problem hiding this comment.
「aria-errormessage」と「の」のあいだですが、こちら（fail）は空白ありで、次の「incomplete」では空白なしになっていました。。
おそらくは前回までに調整ができていなかったわけですが、このあたりは次回までに全体的にこちらでも見直しができればと思っているので、いったんそのままにしましょう。
locales/ja.json
Outdated
| @@ -478,7 +484,8 @@ | |||
| }, | |||
| "incomplete": { | |||
| "noId": "ARIA 属性の要素IDがページ上に存在しません: ${data.needsReview}", | |||
| "ariaCurrent": "ARIA 属性値が無効であるため、\"aria-current=true\" として扱われます: ${data.needsReview}" | |||
| "ariaCurrent": "ARIA 属性値が無効であるため、\"aria-current=true\" として扱われます: ${data.needsReview}", | |||
| "idrefs": "ARIA 属性で指定されている要素の ID がページ上に存在するかどうか判定できません: ${data.needsReview}" | |||
There was a problem hiding this comment.
2行上の"noID"で”ARIA attribute element ID”を「ARIA 属性の要素ID」と訳してしまっているので、もしここで「ARIA 属性で指定されている要素の ID」とするのであれば、そちらもあわせる必要があると思います。
There was a problem hiding this comment.
「ARIA 属性で指定されている要素の ID」は結構意訳だと思いますが、
「ARIA 属性の要素ID」は、個人的には非常に意図が分かりづらいと思ってこうしてみました。
どちらかに統一するのが望ましいと思いますが、どちらが適切でしょう？
ちなみに、noIdの方は、英単語の前後のスペースの有無がこの中で混在してますね。
ややこしいので個人的にはスペース無しで統一で良いような気がしています。
There was a problem hiding this comment.
はい、意図は認識しておりました。もともとの方針としては全体として翻訳用ファイルからは利用されている場所がわかりにくいこともあり直訳を基本としていたのですが、この部分についてはわかりやすくしてもよいと思いました。
ということで、「ARIA属性で指定されている要素のID」（スペースなし）でそれぞれ統一する、という方向でお願いできますでしょうか。
locales/ja.json
Outdated
Comment on lines
648
to
649
| "default": "Element has focusable descendants", | ||
| "notHidden": "Using a negative tabindex on an element inside an interactive control does not prevent assistive technologies from focusing the element (even with 'aria-hidden=true')" |
There was a problem hiding this comment.
Suggested change
| "default": "Element has focusable descendants", | |
| "notHidden": "Using a negative tabindex on an element inside an interactive control does not prevent assistive technologies from focusing the element (even with 'aria-hidden=true')" | |
| "default": "要素の子孫にフォーカス可能なものがあります", | |
| "notHidden": "インタラクティブなコントロールの内側の要素に負の tabindex を指定することで、（'aria-hidden=true' とともに）支援技術がその要素にフォーカスできないようにしています" |
翻訳漏れでしょうか。
There was a problem hiding this comment.
翻訳漏れでした。
defaultはsuggestいただいた通りで良いと思いますが、notHiddenはちょっと意図が違うように思います。 CF: 1577065
role -> ロール Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
role -> ロール Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
陰 -> 影 Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
陰 -> 影 Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
…mplete/{noId,idrefs}
|
@WilcoFiers I believe the review is done (finally). Please check and merge the file if it's OK with you. |
|
Fantastic! Much appreciated again @ma10, and @kiyochika thank you for reviewing. |
WilcoFiers
approved these changes
Mar 7, 2022
straker
pushed a commit
that referenced
this pull request
May 12, 2022
* chore(i18n): update Japanese translation
grunt translate --lang=ja based on the develop branch as of 2021-12-03
Add ja translation for checks/aria-errormessage/fail/hidden
Add ja translation for checks/aria-errormessage/incomplete/idrefs
add ja translation for checks/aria-level/{pass,fail}
Add ja translation for checks/aria-valid-attr-value/incomplete/idrefs
Add ja transation for checks/deprecatedrole/{pass,fail}
Add ja translation for checks/fallbackrole/incomplete
add ja translation for checks/p-as-heading/incomplete
Add ja translation for checks/color-contrast-enhanced/fail/*
Add ja translation for checks/color-contrast/fail/*
* Update locales/ja.json
role -> ロール
Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
* Update locales/ja.json
role -> ロール
Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
* Update locales/ja.json
陰 -> 影
Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
* Update locales/ja.json
陰 -> 影
Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
* Add ja translation for checks/no-focusable-content
* Make checks/aria-valid-attr-value/incomplete/noId consistent with ./idrefs
* Remove unnecessary whitespaces from checks/aria-valid-attr-value/incomplete/{noId,idrefs}
Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
ma10
added a commit
to ma10/axe-core
that referenced
this pull request
May 12, 2023
Remove whitespaces between English words and Japanese characters as agreed previously: dequelabs#3319 rules/accesskeys: wording change rules/aria-focus-hidden: wording change rules/aria-input-field-name/help: wording change rules/aria-roledescription/help: wording change rules/aria-text/description: make the location of the double-quotes consistent with the original text. rules/aria-toggle-field-name/help: change wording rules/aria-tooltip-name/description: wording change rules/aria-treeitem-name/description: wording changes rules/blink/help: correct translation rules/color-contrast-enhanced: correct translation rules/color-contrast: correct translation rules/css-orientation-lock/help: wording change rules/definition-list/help: correct translation rules/duplicate-id-active: wording changes rules/duplicate-id-aria/description: wording change rules/focus-order-semantics: correct translation rules/form-field-multiple-labels/help: wording change rules/frame-focusable-content: correct translation rules/frame-tested/help: change wording rules/frame-title: correct translation rules/hidden-content* correct translation rules/identical-links-same-purpose: correct translation rules/label-title-only/description: correct translation rules/landmark-complementary-is-top-level/help: wording change rules/landmark-one-main/description: correct translation rules/landmark-unique/description: correct translation. rules/link-in-text-block: correct translation rules/meta-refresh-no-exceptions: correct translation rules/meta-refresh: correct translation rules/meta-viewport-large/help: correct translation rules/meta-viewport: correct translation rules/nested-interactive: correct translation rules/no-autoplay-audio/help: correct translation rules/p-as-heading: correct translation rules/presentation-role-conflict: correct translation rules/role-img-alt: correct translation rules/scrollable-region-focusable: correct translation rules/svg-img-alt/help: correct translation rules/tabindex/help: correct translation rules/table-duplicate-name: correct translation rules/table-fake-caption/help: correct translation rules/target-size/help: correct translation rules/td-has-header: correct translation rules/td-headers-attr: correct translation rules/th-has-data-cells: swap the content of help and description to be consistent with the original. checks/aria-allowed-attr/incomplete: correct translation checks/aria-allowed-role/{fail,incomplete: correct translation checks/aria-busy/fail: correct translation checks/aria-errormessage{pass,fail}: correct translation checks/aria-required-children/fail/unallowed: sync with the en version checks/aria-allowed-attr/incomplete: correct translation checks/deprecatedrole/pass: correct translation checks/has-global-aria-attribute: correct translation checks/color-contrast-enhanced/incomplete/pseudoContent: consistent wording with other phrases checks/color-contrast/incomplete/pseudoContent: consistent wording with other phrases checks/pseudoContent/pass: consistent wording with other phrases checks/link-in-text-block/incomplete/{default,bgColorContrast}: correct translation checks/accesskeys: correct translation checks/focusable-disabled: correct translation checks/focusable-modal-open: correct translation checks/focusable-not-tabbable: correct translation checks/landmark-is-top-level/fail: correct translation checks/page-has-main/pass: correct translation checks/alt-space-value/fail: correct translation checks/explicit-label: correct translation checks/help-same-as-label: correct translation checks/hidden-explicit-label: correct translation checks/multiple-label/fail: correct translation checks/landmark-is-unique/pass: correct translation checks/listitem/fail/roleNotValid: correct translation checks/only-dlitems: correct translation checks/only-listitems: correct translation checks/caption/incomplete: correct translation checks/no-autoplay-audio: correct translation checks/css-orientation-lock: correct translation checks/target-offset: correct translation checks/target-size: correct translation checks/header-present: correct translation checks/identical-links-same-purpose/incomplete: correct translation checks/identical-links-same-purpose: correct translation Make the translation of the oword "present" consistent throughout the file. checks/meta-refresh-no-exceptions/fail: correct translation checks/meta-refresh/fail: correct translation checks/p-as-heading/fail: correct translation checks/duplicate-id-aria: correct translation checks/duplicate-id: correct translation checks/button-has-visible-text/{pass,fail}: correct translation checks/has-alt: correct translation checks/important-letter-spacing: correct translation checks/important-line-height: correct translation checks/important-word-spacing: correct translation checks/non-empty-alt/pass: correct translation checks/non-empty-if-present: correct translation checks/non-empty-placeholder: correct translation checks/non-empty-title: correct translation checks/non-empty-value: correct translation checks/presentational-role: correct translation checks/svg-non-empty-title: correct translation checks/caption-faked/pass: typo fix failureSummary/incompleteFallbackMessage: correct translation Make the translation for "role attribute" consistent throughout the file. Add ja translation for checks/aria-conditional-attr
WilcoFiers
added a commit
that referenced
this pull request
Aug 29, 2023
* Chore(i18n): Update and correct Japanese translation Remove whitespaces between English words and Japanese characters as agreed previously: #3319 rules/accesskeys: wording change rules/aria-focus-hidden: wording change rules/aria-input-field-name/help: wording change rules/aria-roledescription/help: wording change rules/aria-text/description: make the location of the double-quotes consistent with the original text. rules/aria-toggle-field-name/help: change wording rules/aria-tooltip-name/description: wording change rules/aria-treeitem-name/description: wording changes rules/blink/help: correct translation rules/color-contrast-enhanced: correct translation rules/color-contrast: correct translation rules/css-orientation-lock/help: wording change rules/definition-list/help: correct translation rules/duplicate-id-active: wording changes rules/duplicate-id-aria/description: wording change rules/focus-order-semantics: correct translation rules/form-field-multiple-labels/help: wording change rules/frame-focusable-content: correct translation rules/frame-tested/help: change wording rules/frame-title: correct translation rules/hidden-content* correct translation rules/identical-links-same-purpose: correct translation rules/label-title-only/description: correct translation rules/landmark-complementary-is-top-level/help: wording change rules/landmark-one-main/description: correct translation rules/landmark-unique/description: correct translation. rules/link-in-text-block: correct translation rules/meta-refresh-no-exceptions: correct translation rules/meta-refresh: correct translation rules/meta-viewport-large/help: correct translation rules/meta-viewport: correct translation rules/nested-interactive: correct translation rules/no-autoplay-audio/help: correct translation rules/p-as-heading: correct translation rules/presentation-role-conflict: correct translation rules/role-img-alt: correct translation rules/scrollable-region-focusable: correct translation rules/svg-img-alt/help: correct translation rules/tabindex/help: correct translation rules/table-duplicate-name: correct translation rules/table-fake-caption/help: correct translation rules/target-size/help: correct translation rules/td-has-header: correct translation rules/td-headers-attr: correct translation rules/th-has-data-cells: swap the content of help and description to be consistent with the original. checks/aria-allowed-attr/incomplete: correct translation checks/aria-allowed-role/{fail,incomplete: correct translation checks/aria-busy/fail: correct translation checks/aria-errormessage{pass,fail}: correct translation checks/aria-required-children/fail/unallowed: sync with the en version checks/aria-allowed-attr/incomplete: correct translation checks/deprecatedrole/pass: correct translation checks/has-global-aria-attribute: correct translation checks/color-contrast-enhanced/incomplete/pseudoContent: consistent wording with other phrases checks/color-contrast/incomplete/pseudoContent: consistent wording with other phrases checks/pseudoContent/pass: consistent wording with other phrases checks/link-in-text-block/incomplete/{default,bgColorContrast}: correct translation checks/accesskeys: correct translation checks/focusable-disabled: correct translation checks/focusable-modal-open: correct translation checks/focusable-not-tabbable: correct translation checks/landmark-is-top-level/fail: correct translation checks/page-has-main/pass: correct translation checks/alt-space-value/fail: correct translation checks/explicit-label: correct translation checks/help-same-as-label: correct translation checks/hidden-explicit-label: correct translation checks/multiple-label/fail: correct translation checks/landmark-is-unique/pass: correct translation checks/listitem/fail/roleNotValid: correct translation checks/only-dlitems: correct translation checks/only-listitems: correct translation checks/caption/incomplete: correct translation checks/no-autoplay-audio: correct translation checks/css-orientation-lock: correct translation checks/target-offset: correct translation checks/target-size: correct translation checks/header-present: correct translation checks/identical-links-same-purpose/incomplete: correct translation checks/identical-links-same-purpose: correct translation Make the translation of the oword "present" consistent throughout the file. checks/meta-refresh-no-exceptions/fail: correct translation checks/meta-refresh/fail: correct translation checks/p-as-heading/fail: correct translation checks/duplicate-id-aria: correct translation checks/duplicate-id: correct translation checks/button-has-visible-text/{pass,fail}: correct translation checks/has-alt: correct translation checks/important-letter-spacing: correct translation checks/important-line-height: correct translation checks/important-word-spacing: correct translation checks/non-empty-alt/pass: correct translation checks/non-empty-if-present: correct translation checks/non-empty-placeholder: correct translation checks/non-empty-title: correct translation checks/non-empty-value: correct translation checks/presentational-role: correct translation checks/svg-non-empty-title: correct translation checks/caption-faked/pass: typo fix failureSummary/incompleteFallbackMessage: correct translation Make the translation for "role attribute" consistent throughout the file. Add ja translation for checks/aria-conditional-attr * Add translation for checks/link-in-text-block-style/incomplete * Add ja translation for rules/aria-deprecated-role * Add ja translation for checks/color-contrast/incomplete/complexTextShadows * Update locales/ja.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * checks/aria-allowed-role/imcomplete: make the wording consistent between singular and plural * Add translation for rules/aria-prohibited-attr * Add translations for rules/aria-braille-equivalent, rules/aria-conditional-attr, checks/braille-label-equivalent, and checks/braille-roledescription-equivalent * Update locales/ja.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update checks/braille-roledescription-equivalent/pass to make it inline with the changes introduced by PR #4133 * Correct the error in the previous commit. --------- Co-authored-by: Masafumi Max NAKANE <ma10@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grunt translate --lang=ja based on the develop branch as of 2021-12-03
Add ja translation for checks/aria-errormessage/fail/hidden
Add ja translation for checks/aria-errormessage/incomplete/idrefs
add ja translation for checks/aria-level/{pass,fail}
Add ja translation for checks/aria-valid-attr-value/incomplete/idrefs
Add ja transation for checks/deprecatedrole/{pass,fail}
Add ja translation for checks/fallbackrole/incomplete
add ja translation for checks/p-as-heading/incomplete
Add ja translation for checks/color-contrast-enhanced/fail/*
Add ja translation for checks/color-contrast/fail/*
<< Describe the changes >>
Closes issue: