Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type issue on getFrameContexts #3371

Closed
WilcoFiers opened this issue Feb 2, 2022 · 1 comment
Closed

type issue on getFrameContexts #3371

WilcoFiers opened this issue Feb 2, 2022 · 1 comment
Labels
fix Bug fixes pr A pr has been created for the issue typescript TypeScript issues

Comments

@WilcoFiers
Copy link
Contributor

The getFrameContexts method will never return DOM Nodes, unlike what its type suggests. This makes serialisation more difficult than it needs to be.
@WilcoFiers WilcoFiers added fix Bug fixes typescript TypeScript issues labels Feb 2, 2022
@WilcoFiers WilcoFiers mentioned this issue Feb 2, 2022
Merged
@straker straker added the pr A pr has been created for the issue label Jul 26, 2022
@padmavemulapati
Copy link

padmavemulapati commented Aug 30, 2022 •
edited

Validated with the latest develop branch code base, tested on test page, http://qateam.dequecloud.com/attest/api/test.html
await axe.utils.getFrameContexts({exclude: [['iframe','#testFrame']] }); and
await axe.utils.getFrameContexts('#testFrame')
its giving return type and with Array objects
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Bug fixes pr A pr has been created for the issue typescript TypeScript issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WilcoFiers @straker @padmavemulapati