Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add Hebrew translation #3438

Merged
merged 5 commits into from Aug 17, 2022
Merged

Conversation

nadavkav
Copy link
Contributor

Translated by Or Bar-Josef from the Weizmann institute of science, Israel.

<< Describe the changes >>

Closes issue:

Translated by Or Bar-Josef from the Weizmann institute of science, Israel.
@nadavkav nadavkav requested a review from a team as a code owner April 17, 2022 12:33
@straker
Copy link
Contributor

straker commented Apr 18, 2022

Thanks for the new translation! We'll find someone to review the changes who can speak Hebrew, so it may take a bit to get a review.

@nadavkav
Copy link
Contributor Author

Thank you @straker

@WilcoFiers WilcoFiers self-assigned this Apr 19, 2022
@straker
Copy link
Contributor

straker commented Aug 1, 2022

Update on this. Thanks for your patience. We found someone to do the review. I'll try to have a pr to your branch with the changes they suggested within the next few days.

@nadavkav
Copy link
Contributor Author

nadavkav commented Aug 1, 2022

Thank you

@straker
Copy link
Contributor

straker commented Aug 11, 2022

@nadavkav Just letting you know I opened a pr on your fork with the suggestions from the translator. Let me know if you have any questions.

@nadavkav
Copy link
Contributor Author

@straker , I can not find the reviewer's suggestions please send a link.
And I do not understand the flow, do I need to do something?

@straker
Copy link
Contributor

straker commented Aug 15, 2022

The suggestions can be found here https://github.com/nadavkav/axe-core/pull/1/files. It's a pr to your fork of axe-core. The flow would be to look at the differences between your file and the suggestions from the pr and if you accept all the changes to merge the pr on your fork. That should automatically update this pr with those changes.

add translation review from translators
@nadavkav nadavkav dismissed a stale review via 97da9bf August 16, 2022 14:33
@straker
Copy link
Contributor

straker commented Aug 16, 2022

@nadavkav thanks for accepting the changes. It looks like our build is failing because your fork is out of date. I'll make another pr to update it for you.

@straker
Copy link
Contributor

straker commented Aug 16, 2022

Here's the pr nadavkav#3

chore: update with latest axe-core develop
@straker straker changed the title New Hebrew he.json feat(i18n): add Hebrew translation Aug 17, 2022
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks again for your patience while we worked to find someone to help us.

@straker
Copy link
Contributor

straker commented Aug 17, 2022

Reviewed for security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants