Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-required-children: be less permissive of divs as child nodes #3462

Closed
WilcoFiers opened this issue May 18, 2022 · 2 comments
Closed

aria-required-children: be less permissive of divs as child nodes #3462

WilcoFiers opened this issue May 18, 2022 · 2 comments
Labels
ACT Rules fix Bug fixes pr A pr has been created for the issue
Milestone

Comments

@WilcoFiers
Copy link
Contributor

ARIA required context role, failed example 3

In the ARIA required context role ACT rules, failed example 3 currently isn't being failed by axe-core. Specifically, I think aria-required-children should have caught this:

<div role="list">
  <div aria-live="polite">
    <div role="listitem">List item 1</div>
    <div role="listitem">List item 2</div>
  </div>
</div>

Because of its global attribute, that div[aria-live] should not be ignored in the accessibility tree. How browsers do this varies. Firefox considers this a section inside a list.

@WilcoFiers WilcoFiers added this to the Axe-core 4.5 milestone May 18, 2022
@straker
Copy link
Contributor

straker commented Aug 10, 2022

Should fail due to #3468, just need to add to the getOwnedRoles function to check for tabindex > -1 or is focusable (should we make this it's own function called includedInAccessibilityTree? We do this type of check often enough it might make sense). Adding null to the list or return roles should be sufficient in this case to trigger the error message.

@padmavemulapati
Copy link

Validated with the latest develop branch code base,
aria-required-children failing now for the child elements which are unlisted

image

and with 4.3.5 we are reproducing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Rules fix Bug fixes pr A pr has been created for the issue
Projects
None yet
Development

No branches or pull requests

3 participants