Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential false positive for role=radiogroup when wrapping a table containing radio buttons #3541

Closed
mfairchild365 opened this issue Jul 12, 2022 · 3 comments
Assignees
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@mfairchild365
Copy link
Contributor

axe throws this error: "Certain ARIA roles must contain particular children" - stating that role=radiogroup is missing required children... even though they are present (but within a table). Interestingly, if role=radiogroup is changed to role=group... axe no longer throws the error.

I believe this may be a false positive.

Here is an example: https://codepen.io/mfairchild365/full/PoRPMqY (please note that this table is intentionally silly... real world examples of this do exist).

Product: axe Extension

Expectation: axe does not throw the above-referenced error

Actual: axe throws the above-referenced error

Motivation: << Describe why you want the behavior to be changed >>


axe-core version: 4.4.2
axe-webdriver, extension or other integration version: 4.31.2
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule labels Jul 12, 2022
@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jul 12, 2022

Thanks Michael, yeah this shouldn't be failed. Unlike something like listitems in lists, radiobuttons do not need to be a direct child of the radiobutton group. What's why this is being failed.

@WilcoFiers WilcoFiers added this to the axe-core 4.5.1 milestone Oct 19, 2022
@WilcoFiers WilcoFiers self-assigned this Nov 21, 2022
@WilcoFiers
Copy link
Contributor

It looks like this was fixed already in axe-core 4.5 in PR #3597.

@WilcoFiers WilcoFiers removed this from the axe-core 4.5.3 milestone Nov 21, 2022
@padmavemulapati
Copy link

Validated with the latest axe-core develop branch code base,
aria-required-children rule is failing when role=menu is like:

<div role="menu">
    <li>Item 1</li>
    <span role="link">Item 2</span>
  </div>

Image

and passing when:

<div id="target" role="menu"><li role="none"></li><li role="menuitem">Item 1</li><div role="menuitemradio">Item 2</div><div role="menuitemcheckbox">Item 3</div></div>

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

3 participants