Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate color.filteredRectStack, color.getRectStack, and dom.visuallyContains #3859

Merged
merged 1 commit into from Jan 18, 2023
Merged

feat: deprecate color.filteredRectStack, color.getRectStack, and dom.visuallyContains #3859

merged 1 commit into from Jan 18, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 17, 2023

Use color.getBackgroundStack instead of color.filteredRectStack or color.getRectStack. dom.visuallyContains has no replacement.

Closes: #3833

@straker straker requested a review from a team as a code owner January 17, 2023 17:00
@straker straker merged commit 3be2bad into develop Jan 18, 2023
@straker straker deleted the deprecate-color-contrast-fns branch January 18, 2023 17:26
@attest-team-ci attest-team-ci mentioned this pull request Jan 20, 2023
Closed
@attest-team-ci attest-team-ci mentioned this pull request Apr 17, 2023
Merged
@Shubhabrata08 Shubhabrata08 mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate commons.color.filteredRectStack, commons.color.getRectStack, and commons.dom.visuallyContains
2 participants
@straker @WilcoFiers