Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): Add missing Japanese rules translations #3941

Merged
merged 16 commits into from
Apr 6, 2023

Conversation

shunito
Copy link
Contributor

@shunito shunito commented Mar 12, 2023

Added translations of Japanese rules that are missing due to recent updates.

@shunito shunito requested a review from a team as a code owner March 12, 2023 04:32
@CLAassistant
Copy link

CLAassistant commented Mar 12, 2023

CLA assistant check
All committers have signed the CLA.

@shunito shunito changed the title Add missing Japanese rules translations chore(i18n): Add missing Japanese rules translations Mar 12, 2023
@straker
Copy link
Contributor

straker commented Mar 13, 2023

Thanks for the pr. We'll need to look for someone who speaks Japanese that can review this, so might be a bit. But we'll make sure to get it merged.

locales/ja.json Outdated
@@ -631,6 +668,7 @@
},
"focusable-not-tabbable": {
"pass": "要素内にフォーカス不可能な要素は含まれていません",
"incomplete": "Check if the focusable elements immediately move the focus indicator",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation is not finished..

@shunito
Copy link
Contributor Author

shunito commented Mar 14, 2023

I found a section that has not been translated yet.
I will add them within a few days.

tabindexを「マイナス」という表現を元の翻訳と合わせ「負」に変更
letter-spacing = 文字の間隔
word-spacing = 単語の間隔
@shunito
Copy link
Contributor Author

shunito commented Mar 15, 2023

@straker Thank you for your usual contributions.
I have added the missing translated text.
and, I have then asked the member who created the original Japanese translation to review it.

@ma10
Copy link
Contributor

ma10 commented Mar 16, 2023

Maybe @kiyochika could review?

tabindexを「マイナス」という表現を元の翻訳と合わせ「負」に変更
letter-spacing = 文字の間隔
word-spacing = 単語の間隔
@straker
Copy link
Contributor

straker commented Apr 6, 2023

Thanks for the translations. Approved for security.

@straker straker merged commit 13aa1f8 into dequelabs:develop Apr 6, 2023
1 of 3 checks passed
@shunito shunito deleted the i18n-ja-translate branch April 7, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants