Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules): deprecate duplicate-id and duplicate-id-active #3957

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Mar 23, 2023

Closes: #3892

@straker straker requested a review from a team as a code owner March 23, 2023 21:07
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR title is a bit misleading in suggesting duplidate-id-aria gets deprecated. How about we put that one in its own PR?

@straker straker changed the title feat(rules): deprecate duplicate-id, duplicate-id-active, and duplicate-id-aria rules feat(rules): deprecate duplicate-id and duplicate-id-active Mar 24, 2023
WilcoFiers
WilcoFiers previously approved these changes Mar 28, 2023
@straker straker merged commit 04a4b5e into develop Mar 29, 2023
3 checks passed
@straker straker deleted the deprecated-duplicate-id branch March 29, 2023 15:08
WilcoFiers added a commit that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update duplicate-id rules to align with WCAG 2.2
2 participants