Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast): correcly apply opacity to foreground color #3973

Merged
merged 5 commits into from Apr 6, 2023
Merged

fix(color-contrast): correcly apply opacity to foreground color #3973

merged 5 commits into from Apr 6, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Apr 3, 2023

Closes: #3924

@straker straker requested a review from a team as a code owner April 3, 2023 20:39
WilcoFiers
WilcoFiers previously approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two minor suggestions for you though.

lib/commons/color/get-foreground-color.js Outdated Show resolved Hide resolved
lib/commons/color/get-foreground-color.js Outdated Show resolved Hide resolved
@straker straker merged commit d7db279 into develop Apr 6, 2023
17 checks passed
@straker straker deleted the opacity-foreground branch April 6, 2023 17:31
@attest-team-ci attest-team-ci mentioned this pull request Apr 17, 2023
Merged
@Shubhabrata08 Shubhabrata08 mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color contrast miscalculates foreground color with opacity
2 participants
@straker @WilcoFiers