Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata): add Trusted Tester tag #3986

Merged
merged 4 commits into from Apr 17, 2023
Merged

feat(metadata): add Trusted Tester tag #3986

merged 4 commits into from Apr 17, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Apr 12, 2023

Closes: #3974

@straker straker requested a review from a team as a code owner April 12, 2023 23:08
"ACT"
"ACT",
"TTv5",
"TT6.a"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ANDI finds these, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

<map name="infographic">
  <area shape="poly" coords="130,147,200,107,254,219,130,228" href="https://developer.mozilla.org/docs/Web/HTML">
</map>
<img usemap="#infographic" src="https://interactive-examples.mdn.mozilla.net/media/examples/mdn-info2.png" alt="MDN infographic">

screenshot of ANDI tool showing accessible name issue for the area element

@@ -2,7 +2,7 @@
"id": "aria-input-field-name",
"selector": "[role=\"combobox\"], [role=\"listbox\"], [role=\"searchbox\"], [role=\"slider\"], [role=\"spinbutton\"], [role=\"textbox\"]",
"matches": "no-naming-method-matches",
"tags": ["cat.aria", "wcag2a", "wcag412", "ACT"],
"tags": ["cat.aria", "wcag2a", "wcag412", "ACT", "TTv5", "TT5.c"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I would have totally picked 5.A on that one, but you're right. Accessible name, not label.

lib/rules/html-xml-lang-mismatch.json Outdated Show resolved Hide resolved
lib/rules/image-alt.json Outdated Show resolved Hide resolved
lib/rules/input-image-alt.json Outdated Show resolved Hide resolved
lib/rules/meta-viewport.json Outdated Show resolved Hide resolved
doc/rule-descriptions.md Show resolved Hide resolved
doc/rule-descriptions.md Show resolved Hide resolved
doc/rule-descriptions.md Show resolved Hide resolved
doc/rule-descriptions.md Show resolved Hide resolved
doc/rule-descriptions.md Show resolved Hide resolved
doc/rule-descriptions.md Show resolved Hide resolved
straker and others added 3 commits April 17, 2023 09:47
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@WilcoFiers WilcoFiers merged commit 1f6a2a6 into develop Apr 17, 2023
17 checks passed
@WilcoFiers WilcoFiers deleted the trusted-tester branch April 17, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add trusted tester tags
2 participants