Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-required-children): trigger reviewEmpty with hidden children #4012

Merged
merged 4 commits into from May 12, 2023

Conversation

WilcoFiers
Copy link
Contributor

When an element such as menu or list is set for review when it's empty, it should also be set for review if it has only hidden content.

Closes: #4010

@WilcoFiers WilcoFiers requested a review from a team as a code owner May 9, 2023 12:51
@WilcoFiers WilcoFiers merged commit a19b6cb into develop May 12, 2023
17 checks passed
@WilcoFiers WilcoFiers deleted the aria-req-children-review-hidden branch May 12, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aria-required-children's reviewEmpty option is broken on hidden children
2 participants