Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aria-required-childen): test visibility of grandchildren #4091

Merged
merged 7 commits into from Jul 27, 2023
Merged

fix(aria-required-childen): test visibility of grandchildren #4091

merged 7 commits into from Jul 27, 2023

Conversation

WilcoFiers
Copy link
Contributor

Closes: #4090

@WilcoFiers WilcoFiers marked this pull request as ready for review July 17, 2023 10:52
@WilcoFiers WilcoFiers requested a review from a team as a code owner July 17, 2023 10:52
straker
straker previously requested changes Jul 24, 2023
View reviewed changes
test/checks/aria/required-children.js Outdated Show resolved Hide resolved
@WilcoFiers @straker
Apply suggestions from code review
6856b87 
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
@WilcoFiers WilcoFiers merged commit a202b69 into develop Jul 27, 2023
17 checks passed
@WilcoFiers WilcoFiers deleted the aria-children-double-hidden branch July 27, 2023 11:34
@attest-team-ci attest-team-ci mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@WilcoFiers @straker