Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast): process non-rgb color functions #4092

Merged
merged 4 commits into from Jul 27, 2023
Merged

fix(color-contrast): process non-rgb color functions #4092

merged 4 commits into from Jul 27, 2023

Conversation

WilcoFiers
Copy link
Contributor

Prevent color-contrast from erroring out when non-RGB color spaces are used.

Closes: #4080

@WilcoFiers WilcoFiers requested a review from a team as a code owner July 17, 2023 11:25
straker
straker previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing (can merge if you'd like). Regex is complicated so a comment above will help clarify the purpose of the matching.

lib/commons/color/parse-text-shadows.js Show resolved Hide resolved
@WilcoFiers WilcoFiers merged commit 9634282 into develop Jul 27, 2023
17 checks passed
@WilcoFiers WilcoFiers deleted the text-shadow-color-space branch July 27, 2023 11:34
@attest-team-ci attest-team-ci mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color-contrast errors out on CSS color spaces in text-shadow
2 participants
@WilcoFiers @straker