Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commons/dom/createGrid): only add the visible, non-overflow areas of an element to the grid #4101

Merged
merged 3 commits into from Jul 28, 2023
Merged

fix(commons/dom/createGrid): only add the visible, non-overflow areas of an element to the grid #4101

merged 3 commits into from Jul 28, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 24, 2023

Implementing #3923 (comment)

Closes: #3923

@straker straker requested a review from a team as a code owner July 24, 2023 19:51
WilcoFiers
WilcoFiers previously requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have an integration test that demonstrates the memory problem, and shows it's solved. Have you tried that?

WilcoFiers
WilcoFiers previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion though.

test/integration/full/contrast/memory.html Outdated Show resolved Hide resolved
@straker @WilcoFiers
Update test/integration/full/contrast/memory.html
df02c24 
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@straker straker merged commit d77f47b into develop Jul 28, 2023
17 checks passed
@straker straker deleted the create-grid-overflow branch July 28, 2023 14:12
@attest-team-ci attest-team-ci mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createGrid consumes excessive memory and crashes on pages with extremely large elements
2 participants
@straker @WilcoFiers